Ct 355/migrate simple seed #5013

VersusFacit · 2022-04-08T11:56:27Z

Migrates most (soon all) of 005 simple seed.

Description

Using my best judgement of the test framework, I've gotten these tests working locally! There are two main TODOs where I'm sure there is a better way to accomplish things than the ideas I was able to come up with. I'll mark with inline comments. Please do suggest things so I can get them ship-shape.

Updated:

I've figured out how to get all the tests working per the issues stated above.

Checklist

I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have added information about my change to be included in the CHANGELOG.

github-actions · 2022-04-08T11:56:45Z

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

tests/functional/simple_seed/test_seed.py

VersusFacit · 2022-04-08T11:57:36Z

tests/functional/simple_seed/test_seed.py

+        check_table_does_exist(project.adapter, "seed_enabled")
+        check_table_does_not_exist(project.adapter, "seed_disabled")
+        check_table_does_exist(project.adapter, "seed_tricky")
+        # TODO: 1/3 is there a better way to enforce cleanup


So this is required cleanup. I'm guessing there is a better way to reset the database after every test_ when using the def seeds fixture in a test class.

You can have your setup fixture do it by doing the setup, yield something and do the drop table after yield. Examples

We do now have project.drop_test_schema(). I haven't tested it for this use case, but it should work.

I tried to get the project.drop_test_schema() to work but no dice. Digging into the code didn't reveal any answers. Opted for this instead:

182 @pytest.fixture(scope="function") 183 def clear_test_schema(self, project): 184 yield 185 project.run_sql(f"drop schema if exists {project.test_schema} cascade") 186 187 def test_postgres_simple_seed_with_disabled(self, clear_test_schema, project):

ChenyuLInx

This looks great!!!

tests/functional/simple_seed/test_seed.py

ChenyuLInx · 2022-04-08T14:12:44Z

tests/functional/simple_seed/test_seed.py

+        check_table_does_exist(project.adapter, "seed_enabled")
+        check_table_does_not_exist(project.adapter, "seed_disabled")
+        check_table_does_exist(project.adapter, "seed_tricky")
+        # TODO: 1/3 is there a better way to enforce cleanup


You can have your setup fixture do it by doing the setup, yield something and do the drop table after yield. Examples

tests/functional/simple_seed/test_seed.py

ChenyuLInx · 2022-04-08T14:21:22Z

tests/functional/simple_seed/test_seed.py

+        # check_relations_equal(project.adapter, ["seed_actual", "seed_expected"])
+
+
+class TestSimpleSeedEnabledViaConfig(object):


@gshank @VersusFacit How do you guys feel about moving this to selection(graph selection?) tests? since this is mainly testing the selection functionality

I could weigh in better if I understood the primacy of the selection feature. Do we consider it a subfeature of seed or do we consider seed a command which mixes in the selection behavior. I feel like that reasoning best informs whether it should be moved to a selection test or not.

tests/functional/simple_seed/test_seed.py

gshank

Looks good, but needs a few minor changes.

tests/functional/simple_seed/test_seed.py

gshank · 2022-04-08T14:43:53Z

tests/functional/simple_seed/test_seed.py

+        )
+
+
+class TestSeedConfigFullRefreshOn(SeedTestBase):


Just a reminder that if these tests are moved into the adapter zone, they'll all have to have names that don't start with 'Test' and a simple class wrapper that does start with 'Test'. Doesn't have to be done now though.

tests/functional/simple_seed/test_seed.py

gshank · 2022-04-08T14:47:38Z

tests/functional/simple_seed/test_seed.py

+        check_table_does_exist(project.adapter, "seed_enabled")
+        check_table_does_not_exist(project.adapter, "seed_disabled")
+        check_table_does_exist(project.adapter, "seed_tricky")
+        # TODO: 1/3 is there a better way to enforce cleanup


We do now have project.drop_test_schema(). I haven't tested it for this use case, but it should work.

tests/functional/simple_seed/test_seed.py

gshank

I have no idea what's up with the postgres error on Windows:
[DEBUG] configured_file: 22:21:45.398957 [debug] [MainThread]: On _test: /* {"app": "dbt", "dbt_version": "1.1.0b1", "profile_name": "test", "target_name": "default", "connection_name": "_test"} /
with diff_count as (
SELECT
1 as id,
COUNT() as num_missing FROM (
(SELECT "birthday", "email", "first_name", "ip_address", "seed_id" FROM "dbt"."test16495429020601287135_test_seed"."seed_expected" EXCEPT
SELECT "birthday", "email", "first_name", "ip_address", "seed_id" FROM "dbt"."test16495429020601287135_test_seed"."seed_bom")
UNION ALL
(SELECT "birthday", "email", "first_name", "ip_address", "seed_id" FROM "dbt"."test16495429020601287135_test_seed"."seed_bom" EXCEPT
SELECT "birthday", "email", "first_name", "ip_address", "seed_id" FROM "dbt"."test16495429020601287135_test_seed"."seed_expected")
) as a
), table_a as (
SELECT COUNT() as num_rows FROM "dbt"."test16495429020601287135_test_seed"."seed_expected"
), table_b as (
SELECT COUNT() as num_rows FROM "dbt"."test16495429020601287135_test_seed"."seed_bom"
), row_count_diff as (
select
1 as id,
table_a.num_rows - table_b.num_rows as difference
from table_a, table_b
)
select
row_count_diff.difference as row_count_difference,
diff_count.num_missing as num_mismatched
from row_count_diff
join diff_count using (id)
[DEBUG] configured_file: 22:21:45.398957 [debug] [MainThread]: Postgres adapter: Postgres error: column "seed_id" does not exist
LINE 7: ... "birthday", "email", "first_name", "ip_address", "seed_id" ...
^
HINT: There is a column named "seed_id" in table "SELECT 1", but it cannot be referenced from this part of the query.

gshank · 2022-04-12T16:57:41Z

It looks like the current failure is in pytest-csv and is due to codepage 1252. So it could be that that pytest plugin isn't compatible with unicode csv files. But I have no idea how the previous error got turned into this error...

ChenyuLInx · 2022-04-13T17:53:02Z

tests/functional/simple_seed/test_seed.py

+        shutil.copyfile(
+            project.test_data_dir / Path("seed_bom.csv"),
+            project.project_root / Path("seeds") / Path("seed_bom.csv"),
+        )


@gshank this is currently being used to copy the csv file over to project seed dir. I wonder which part actually uses pytest_csv

It looks like pytest-csv is for creating test reports in csv format. So I have no idea how it got involved, but I saw it in the error log.

VersusFacit · 2022-04-14T06:48:13Z

At last! On remembering some scattered notes about unicode I studied some 2ish months ago, I got the idea that the encoding for the unicode file might be cp1252 on Windows. Using the system codepoints and manually enforcing the encoding resolves this (Gerda suggested this yesterday I see and I wish I had seen it sooner!)

The insight came from comparing what the default behavior of open was on Windows vs. Unix-systems. I need to move some more things around and this PR is a mess. I'll reopen shortly for a much cleaner experience. :)

VersusFacit added 2 commits April 7, 2022 18:44

(finally) idiomatically rewrite a class of tests into the new framework.

bbac6b3

Get simple seed mostly working with design tweaks needed.

72d9c0a

VersusFacit self-assigned this Apr 8, 2022

VersusFacit requested a review from a team as a code owner April 8, 2022 11:56

VersusFacit requested review from ChenyuLInx and McKnight-42 April 8, 2022 11:56

cla-bot bot added the cla:yes label Apr 8, 2022

VersusFacit commented Apr 8, 2022

View reviewed changes

tests/functional/simple_seed/test_seed.py Outdated Show resolved Hide resolved

VersusFacit commented Apr 8, 2022

View reviewed changes

VersusFacit marked this pull request as draft April 8, 2022 12:02

ChenyuLInx reviewed Apr 8, 2022

View reviewed changes

gshank requested changes Apr 8, 2022

View reviewed changes

VersusFacit added 2 commits April 9, 2022 03:33

Revamp tests to use more of the framework. Fix TODOs

096da33

Complete migration of 005 and remove old files.

f987741

VersusFacit force-pushed the CT-355/migrate_simple_seed branch from 4a36d38 to f987741 Compare April 9, 2022 11:03

adding changelog entry

9dbb7f1

VersusFacit requested review from gshank and ChenyuLInx April 9, 2022 11:07

VersusFacit marked this pull request as ready for review April 9, 2022 11:15

VersusFacit requested a review from a team April 9, 2022 11:15

VersusFacit requested a review from a team as a code owner April 9, 2022 11:15

VersusFacit added 3 commits April 9, 2022 04:45

Attempt to fix undefinedcolumn error likely from double quotes.

ab50eb7

Rewrite fixture for seed BOM test.

a6d5ae0

Change seed id column names to fix windows error.

d01037c

VersusFacit force-pushed the CT-355/migrate_simple_seed branch from 6299c8f to d01037c Compare April 9, 2022 22:10

gshank requested changes Apr 11, 2022

View reviewed changes

VersusFacit mentioned this pull request Apr 11, 2022

[CT-288] Pytest Conversion Tracking #4788

Open

72 tasks

Testing: printing the column names on windows

fc996c5

VersusFacit added 3 commits April 11, 2022 14:01

Testing: printing the column names on windows take 2

65c59bc

Testing: printing the column names on windows take 3

9d04938

Testing: printing the column names on windows take 4

b717531

ChenyuLInx reviewed Apr 13, 2022

View reviewed changes

Trying one more idea.

4611d52

VersusFacit closed this Apr 14, 2022

This was referenced Apr 14, 2022

Ct 355/migrate simple seed #5059

Closed

Ct 488/migrate simple seed #5060

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ct 355/migrate simple seed #5013

Ct 355/migrate simple seed #5013

VersusFacit commented Apr 8, 2022 •

edited

Loading

github-actions bot commented Apr 8, 2022

VersusFacit Apr 8, 2022

ChenyuLInx Apr 8, 2022

gshank Apr 8, 2022

VersusFacit Apr 9, 2022

ChenyuLInx left a comment

ChenyuLInx Apr 8, 2022

ChenyuLInx Apr 8, 2022

VersusFacit Apr 9, 2022

gshank left a comment

gshank Apr 8, 2022

gshank Apr 8, 2022

gshank left a comment

gshank commented Apr 12, 2022

ChenyuLInx Apr 13, 2022 •

edited

Loading

gshank Apr 13, 2022

VersusFacit commented Apr 14, 2022

		# check_relations_equal(project.adapter, ["seed_actual", "seed_expected"])


		class TestSimpleSeedEnabledViaConfig(object):

Ct 355/migrate simple seed #5013

Ct 355/migrate simple seed #5013

Conversation

VersusFacit commented Apr 8, 2022 • edited Loading

Description

Updated:

Checklist

github-actions bot commented Apr 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenyuLInx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gshank left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gshank left a comment

Choose a reason for hiding this comment

gshank commented Apr 12, 2022

ChenyuLInx Apr 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VersusFacit commented Apr 14, 2022

VersusFacit commented Apr 8, 2022 •

edited

Loading

ChenyuLInx Apr 13, 2022 •

edited

Loading