python 3.10 support #4866
Merged
python 3.10 support #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
gshank
requested changes
Mar 15, 2022
core/dbt/tests/fixtures/project.py
Outdated
| @@ -14,6 +15,13 @@ | |||
|
|
|||
| # These are the fixtures that are used in dbt core functional tests | |||
|
|
|||
| # Logbook warnings are ignored so we don't have to fork logbook to support python 3.10. | |||
| # This _only_ works for tests in `tests/` that use the project fixture. | |||
| @pytest.fixture(scope="class") | |||
There was a problem hiding this comment.
I don't think this needs to be a fixture because I can't conceive of a situation in which a test would want to turn the warning back on. So I think it would be better to just put it in the code, maybe right above setup_event_handler in the project fixture?
There was a problem hiding this comment.
Fair enough. Updated!
gshank
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4562 / CT-30
Description
Fixes known 3.10 bugs and logbook deprecations triggered by using 3.10
Checklist