-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added no-print flag #4854
Added no-print flag #4854
Conversation
CHANGELOG.md
Outdated
@@ -18,6 +18,7 @@ | |||
- Allow unique_key to take a list ([#2479](https://github.com/dbt-labs/dbt-core/issues/2479), [#4618](https://github.com/dbt-labs/dbt-core/pull/4618)) | |||
- Add `--quiet` global flag and `print` Jinja function ([#3451](https://github.com/dbt-labs/dbt-core/issues/3451), [#4701](https://github.com/dbt-labs/dbt-core/pull/4701)) | |||
- Add space before justification periods ([#4737](https://github.com/dbt-labs/dbt-core/issues/4737), [#4744](https://github.com/dbt-labs/dbt-core/pull/4744)) | |||
- Add `--no-print` global flag ([#4710](https://github.com/dbt-labs/dbt-core/issues/4710)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've updated the process we use to generate changelogs so that you no longer have to manually figure out where they go. That's also what the cause of the failing GitHub action is. You'll need to delete this line and then go through the new process. You can see the details of how to do it in our Contributing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @emmyoop! I've updated the changelog following the new process and I've just pushed the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this has been sitting for so long! It's looking great. Once you fix the changelog issue and the tests run successfully I'll take another look.
@poloaraujo do you think you can do changes mentioned by @emmyoop regarding the CHANGELOG.md ? We need this PR merged ;) |
Hi @sansar-choinyambuu and @emmyoop! I'm sorry for the huge delay. I've updated the changelog following the new process and I've pushed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I suggested just a small change to the changelog entry. The yaml file can be modified. No need to re-run the changie command!
Co-authored-by: Emily Rockman <[email protected]>
@emmyoop thanks! I've committed your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added no-print flag * Updated changelog * Updated changelog * Removed changes from CHANGELOG.md * Updated CHANGELOG.MD with changie * Update .changes/unreleased/Features-20220408-114118.yaml Co-authored-by: Emily Rockman <[email protected]> Co-authored-by: Emily Rockman <[email protected]>
* Added no-print flag * Updated changelog * Updated changelog * Removed changes from CHANGELOG.md * Updated CHANGELOG.MD with changie * Update .changes/unreleased/Features-20220408-114118.yaml Co-authored-by: Emily Rockman <[email protected]> Co-authored-by: Emily Rockman <[email protected]>
resolves #4710
Description
Add a flag to suppress
{{ print(msg) }}
messages coming out of macros.print
functionality in macros was added in as part of #3451 but there is currently no way to keep the messages from being printed to stdout. This can result in these messages interspersed with logs going to stdout; macros using print() will always have the messages they are printing as an output.Describe alternative you've considered
Not doing this simply means that
{{ print(msg) }}
will always print to stdout.Who will this benefit?
Right now, anything sent to stdout using
{{ print(msg) }}
will get printed to stdout all the time with no way to suppress it. This will allow anyone using macros utilizing print to suppress those messages.Checklist