Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change InvalidRefInTestNode level to DEBUG #4647

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jan 31, 2022

[v1.0.2]

resolves #4594

Description

Change InvalidRefInTestNode event to:

  • Restore previous (pre-v1.0) behavior for this message's log level (DEBUG, not WARN) — thereby decluttering stdout for users of packages that enable/disable models as a common pattern
  • Remove ui.warning_tag for consistency — why include the word WARNING when it's DEBUG?

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Jan 31, 2022
@jtcohen6 jtcohen6 marked this pull request as ready for review January 31, 2022 15:20
@jtcohen6 jtcohen6 requested a review from a team as a code owner January 31, 2022 15:20
@jtcohen6 jtcohen6 requested review from emmyoop and kwigley and removed request for a team January 31, 2022 15:20
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@jtcohen6 jtcohen6 added the backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch label Jan 31, 2022
@jtcohen6 jtcohen6 merged commit aafa1c7 into main Jan 31, 2022
@jtcohen6 jtcohen6 deleted the fix/test-disabled-loglevel branch January 31, 2022 17:28
@github-actions
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4647-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 aafa1c7f473988bb1771b7cf5b120efab44a8144
# Push it to GitHub
git push --set-upstream origin backport-4647-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-4647-to-1.0.latest.

@jtcohen6 jtcohen6 added backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch and removed backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch labels Jan 31, 2022
@github-actions
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4647-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 aafa1c7f473988bb1771b7cf5b120efab44a8144
# Push it to GitHub
git push --set-upstream origin backport-4647-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-4647-to-1.0.latest.

jtcohen6 added a commit that referenced this pull request Feb 1, 2022
* Debug-level test depends on disabled

* Add PR link to Changelog
jtcohen6 added a commit that referenced this pull request Feb 1, 2022
* Debug-level test depends on disabled

* Add PR link to Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-71] Restore previous behavior when a test depends on a disabled (vs. missing) resource
2 participants