Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Jira mirroring workflows to point to shared Actions #4615

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

leahwicz
Copy link
Contributor

Description

I moved all Jira mirroring Actions into a repo that can be referenced by all our repos and reused so we don't need to worry about copying and pasting the same logic everywhere. We can just point each repo to look at this https://github.com/dbt-labs/jira-actions/tree/main/.github/workflows

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be any potential gaps we should manually check to make sure we didn't miss anything when we switch over to the new system?

@leahwicz
Copy link
Contributor Author

Will there be any potential gaps we should manually check to make sure we didn't miss anything when we switch over to the new system?

@nathaniel-may by gaps do you mean like a loss in functionality or new regression introduced?

@nathaniel-may
Copy link
Contributor

do you mean like a loss in functionality or new regression introduced?

@leahwicz I mean the actions missed a ticket because it was submitted while the switch was happening.

@leahwicz
Copy link
Contributor Author

Oh gotcha @nathaniel-may! The creation and labeling will not miss a beat since the Action itself is only being edited so it will still trigger either with the old or new logic which does the same thing. The close workflow is currently broken in the repo so renaming it won't matter since it wasn't working to begin with 😞.

@leahwicz
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jan 24, 2022
@cla-bot
Copy link

cla-bot bot commented Jan 24, 2022

The cla-bot has been summoned, and re-checked this pull request!

@leahwicz leahwicz merged commit f467fba into main Jan 24, 2022
@leahwicz leahwicz deleted the leahwicz/jiraNew branch January 24, 2022 17:20
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@emmyoop emmyoop mentioned this pull request May 12, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants