Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated DepsStartPackageInstall event to use package name #4482

Merged
merged 2 commits into from
Dec 14, 2021
Merged

updated DepsStartPackageInstall event to use package name #4482

merged 2 commits into from
Dec 14, 2021

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 14, 2021

resolves #4461

Description

Updated DepsStartPackageInstall to use package name instead of version number. Log output is now

(env) emily@Emily-Rockman jaffle-shop % dbt deps
12:53:38  Running with dbt=1.0.0
12:53:39  Installing dbt-labs/dbt_utils
12:53:39    Installed from version 0.8.0
12:53:39    Up to date!

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Dec 14, 2021
nathaniel-may
nathaniel-may approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left an alternative I think would be slightly better. If it's not worth the work, this is definitely good enough to merge in.

core/dbt/events/types.py Show resolved Hide resolved
@emmyoop emmyoop merged commit 51f2daf into main Dec 14, 2021
@emmyoop emmyoop deleted the er/core-17-package-name branch December 14, 2021 20:25
emmyoop added a commit that referenced this pull request Dec 14, 2021
@emmyoop
updated DepsStartPackageInstall event to use package name (#4482)
ab768ba 
* updated event to user package name

* add changelog
@emmyoop emmyoop mentioned this pull request Dec 14, 2021
Merged
emmyoop added a commit that referenced this pull request Dec 14, 2021
@emmyoop
updated DepsStartPackageInstall event to use package name (#4482) (#4485
76c2e18 
)

* updated event to user package name

* add changelog
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@emmyoop @iknox-fa
updated DepsStartPackageInstall event to use package name (#4482)
c736503 
* updated event to user package name

* add changelog

automatic commit by git-black, original commits:
  51f2daf
@aranke aranke mentioned this pull request May 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathaniel-may nathaniel-may nathaniel-may approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CORE-17] [Bug] dbt deps doesn't show which packages are installing in the logs
2 participants
@emmyoop @nathaniel-may