made change to test of str

[McKnight-42]

resolves #4433

Description

redefined status param of SQLQueryStatus to typecheck. string which passes on ._message value of AdapterResponse or the str value sent by adapter plugin.

Worked with Nate going through process of dealing with issues as they come in with minimal context, talked through several potential ways to solve the issue and even found some that would cause a bigger change than currently needed so had to take into account what might be worth time investment of task.

-- Co Author @nathaniel-may

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change

[nathaniel-may]

The other alternative we considered was to have the status field of SQLQueryStatus take a value of type Union[AdapterResponse, str] and do the to string logic inside the event module. However, we would have had to move the definition of the AdapterResponse class to avoid circular imports, and override the asdict method to make json serialization work for AdapterResponse values. Since the plan is to eventually enforce the get_response method to return an AdapterResponse, such that we could rely on calling ._message, making the more complex change didn't seem worth it for the short term.

__str__ is appropriately defined for AdapterResponse so calling str at the call site is both simple and a graceful way to handle this for a patch in v1.0.1.

[nathaniel-may]

Let's just add a changelog entry before we merge.

[leahwicz]

@McKnight-42 this change will need to be backported to the 1.0.latest branch. If you need help with that, let me know

[McKnight-42]

@leahwicz would love to set up time to walk through that process