-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change json override strategy #4396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
commented
Dec 2, 2021
nathaniel-may
requested review from
emmyoop,
iknox-fa,
jtcohen6,
gshank and
leahwicz
December 2, 2021 18:23
nathaniel-may
commented
Dec 2, 2021
data[field] = f"JSON_SERIALIZE_FAILED: {type(value).__name__, 'NA'}" | ||
log_line = dict() | ||
try: | ||
log_line = dataclasses.asdict(e, dict_factory=type(e).asdict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the heart of the change.
leahwicz
approved these changes
Dec 2, 2021
gshank
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me. We should definitely look at other serialization options in the near future though.
emmyoop
approved these changes
Dec 2, 2021
leahwicz
pushed a commit
that referenced
this pull request
Dec 2, 2021
4 tasks
leahwicz
added a commit
that referenced
this pull request
Dec 2, 2021
Co-authored-by: Nathaniel May <[email protected]>
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4392
Description
Previously we were overriding on a per field basis. However, some of the serialization problems came one step earlier when we called
asdict.
This allows concrete classes to define their own dict factory methods to override the serialization strategy earlier in the pipeline.This is very manual and definitely not optimized, so we may want to explore using something like mashumaro instead after the initial release.
Checklist
CHANGELOG.md
and added information about my change