Logging README #4395
Merged
Logging README #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
suggested changes
Dec 2, 2021
core/dbt/events/README.md
Outdated
|
|
||
| ## Optional (based on your event) | ||
|
|
||
| - Events associated with node status changes must have `report_node_data` passed in and be extended with `Cache` |
There was a problem hiding this comment.
we should mention extending the NodeInfo class if that's right.
core/dbt/events/README.md
Outdated
| ## Required for Every Event | ||
|
|
||
| - A unique `code` that indicates the type | ||
| - a loglevel |
There was a problem hiding this comment.
I'd follow suit with the 4th bullet and mention extending the class with an example.
leahwicz
approved these changes
Dec 2, 2021
core/dbt/events/README.md
Outdated
| ## Optional (based on your event) | ||
|
|
||
| - Events associated with node status changes must have `report_node_data` passed in and be extended with `Cache` | ||
| - define `asdict` if your data is not serializable |
nathaniel-may
approved these changes
Dec 2, 2021
leahwicz
pushed a commit
that referenced
this pull request
Dec 2, 2021
* WIP * more README cleanup * readme tweaks * small tweaks * wording updates
leahwicz
added a commit
that referenced
this pull request
Dec 2, 2021
* WIP * more README cleanup * readme tweaks * small tweaks * wording updates Co-authored-by: Emily Rockman <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update logging README to reflect current state
Checklist
CHANGELOG.mdand added information about my change