-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move event code up a level #4381
Conversation
This makes a lot of sense but do we want to also pull out the |
@emmyoop I'm only seeing node info once at the top level already. Where are you seeing it duplicated? example from a run I just did:
|
I should have said we should skip |
Ahh I see. I just added the ignore for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good!
move event code up a level plus minor fixes
move event code up a level plus minor fixes Co-authored-by: Nathaniel May <[email protected]>
move event code up a level plus minor fixes automatic commit by git-black, original commits: 41ed976
Description
code was previously under data. but I think it makes more sense at the top level.
Checklist
CHANGELOG.md
and added information about my change