Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the stdout logger actually go to stdout #4368

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Make the stdout logger actually go to stdout #4368

merged 1 commit into from
Nov 30, 2021

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 30, 2021

resolves #4367

Description

The stdout logs were going to stderr. Fix to go to stdout.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 30, 2021
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! who would have thought the default wasn't stdout. Thanks for this fix!

@gshank gshank merged commit e93ad5f into main Nov 30, 2021
@gshank gshank deleted the fix_stdout branch November 30, 2021 22:48
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 1, 2021

Do we need to backport this to 1.0.latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure stdout logger goes to stdout.
3 participants