Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved teensy bugs uncovered during the bug bash!
Avoid deprecation warning if irrelevant
This is a reasonable thing many users will do:
dbt_modules
has been renamed todbt_packages
dbt_packages
toclean-targets
(but leavingdbt_modules
in there still)Let's consider the deprecation warning "addressed" by that change, and stop raising it. Alternatively, if they do want to keep using
dbt_modules
and configurepackages-install-path: "dbt_modules"
, we shouldn't raise the warning.Use actual (bad) profile name
dbt clean
+dbt deps
are supposed to work even with an invalid database connection (profile). One easy way to test this is by running with, e.g.,dbt clean --profile badprof
.@joellabes and I noticed that dbt uses the profile name specified in
dbt_project.yml
instead of the one specified in the CLI arg:This PR would have us use
Profile.pick_profile_name
to find the right profile name for the log message. Voila: