Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I noticed a few weird things this morning:
cannot_parse
results in anonymous usage tracking for v1 — many more than I'd expect if we're only sampling one out of every 50k modelsdbt --no-partial-parse parse
("cold parse") in our internal analytics project is taking 15-16 seconds, instead of 7-8 seconds. Indeed, that extra time is spent in tracking:Fix
We're firing a tracking event every single time the stable parser
cannot_parse
(orhas_banned_macro
). Instead, we should only populate the tracking result if we're sampling. When I make this change, a "cold parse" of our internal analytics project takes 7-8 seconds again. Hooray!While here:
experimental_sample
, too, and firing a differently coded event depending (0x
vs.8x
)Checklist
CHANGELOG.md
and added information about my change