[#4253] Support partial parsing of env_vars in metrics definitions #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
approved these changes
Nov 23, 2021
jtcohen6
reviewed
Nov 23, 2021
CHANGELOG.md
Outdated
| ### Fixes | ||
| - Correct definition of 'created_at' in ParsedMetric nodes ([#4298](http://github.com/dbt-labs/dbt-core/issues/4298), [#4299](https://github.com/dbt-labs/dbt-core/pull/4299)) | ||
| - Correct definition of 'created_at' in ParsedMetric nodes ([#4298](https://github.com/dbt-labs/dbt-core/issues/4298), [#4299](https://github.com/dbt-labs/dbt-core/pull/4299)) | ||
| - Support partial parsing of env_vars in metrics ([#4253](https://github.com/dbt-labs/dbt-core/issues/4293), [#4322](https://github.com/dbt-labs/dbt-core/pull/4322)) |
There was a problem hiding this comment.
Note for future, doesn't need to happen in this PR: move changelog entry up since this wasn't included in rc2
test/integration/068_partial_parsing_tests/test-files/env_var_metrics.yml
Show resolved
Hide resolved
gshank
force-pushed
the
pp_metrics_env_vars
branch
from
23cc2c2 to
7c9d0a1
Compare
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4253
Description
Because of parallel development of the metrics feature and partial parsing with environment variables, some code was missing to support re-parsing metrics when env_vars change.
Checklist
CHANGELOG.mdand added information about my change