Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task call sites part 1 #4183

Merged
merged 18 commits into from
Nov 2, 2021
Merged

task call sites part 1 #4183

merged 18 commits into from
Nov 2, 2021

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 2, 2021

Description

Modifying call sites for structured logging in core/dbt/task

This directory has a lot of logging so splitting it up for the purposes of smaller reviews.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@emmyoop emmyoop marked this pull request as draft November 2, 2021 14:24
@emmyoop emmyoop changed the base branch from main to feature/structured-logging November 2, 2021 14:51
@cla-bot cla-bot bot added the cla:yes label Nov 2, 2021
@emmyoop emmyoop force-pushed the er/sl-task branch 2 times, most recently from fa86598 to 71dbdda Compare November 2, 2021 16:20
@emmyoop emmyoop marked this pull request as ready for review November 2, 2021 18:42
@emmyoop emmyoop mentioned this pull request Nov 2, 2021
4 tasks
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmyoop emmyoop merged commit 9610342 into feature/structured-logging Nov 2, 2021
@emmyoop emmyoop deleted the er/sl-task branch November 2, 2021 20:53
@nathaniel-may nathaniel-may mentioned this pull request Nov 8, 2021
21 tasks
emmyoop added a commit that referenced this pull request Nov 8, 2021
* add struct logging to base.py

* struct logging in run_operation

* add struct logging to base

* add struct logging to clean

* add struct logging to debug

* add struct logging to deps

* fix errors

* add struct logging to run.py

* fixed flake error

* add struct logging to geneerate

* added debug level stack trace

* fixed flake error

* added struct logging to compile

* added struct logging to freshness

* cleaned up errors

* resolved bug that broke everything

* removed accidental import

* fixed bug with unused args
emmyoop added a commit that referenced this pull request Nov 8, 2021
* add struct logging to base.py

* struct logging in run_operation

* add struct logging to base

* add struct logging to clean

* add struct logging to debug

* add struct logging to deps

* fix errors

* add struct logging to run.py

* fixed flake error

* add struct logging to geneerate

* added debug level stack trace

* fixed flake error

* added struct logging to compile

* added struct logging to freshness

* cleaned up errors

* resolved bug that broke everything

* removed accidental import

* fixed bug with unused args
kwigley pushed a commit that referenced this pull request Nov 9, 2021
* add struct logging to base.py

* struct logging in run_operation

* add struct logging to base

* add struct logging to clean

* add struct logging to debug

* add struct logging to deps

* fix errors

* add struct logging to run.py

* fixed flake error

* add struct logging to geneerate

* added debug level stack trace

* fixed flake error

* added struct logging to compile

* added struct logging to freshness

* cleaned up errors

* resolved bug that broke everything

* removed accidental import

* fixed bug with unused args
nathaniel-may pushed a commit that referenced this pull request Nov 9, 2021
* add struct logging to base.py

* struct logging in run_operation

* add struct logging to base

* add struct logging to clean

* add struct logging to debug

* add struct logging to deps

* fix errors

* add struct logging to run.py

* fixed flake error

* add struct logging to geneerate

* added debug level stack trace

* fixed flake error

* added struct logging to compile

* added struct logging to freshness

* cleaned up errors

* resolved bug that broke everything

* removed accidental import

* fixed bug with unused args
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* add struct logging to base.py

* struct logging in run_operation

* add struct logging to base

* add struct logging to clean

* add struct logging to debug

* add struct logging to deps

* fix errors

* add struct logging to run.py

* fixed flake error

* add struct logging to geneerate

* added debug level stack trace

* fixed flake error

* added struct logging to compile

* added struct logging to freshness

* cleaned up errors

* resolved bug that broke everything

* removed accidental import

* fixed bug with unused args

automatic commit by git-black, original commits:
  281d249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants