-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task call sites part 1 #4183
Merged
Merged
task call sites part 1 #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
force-pushed
the
er/sl-task
branch
2 times, most recently
from
November 2, 2021 16:20
fa86598
to
71dbdda
Compare
nathaniel-may
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
* add struct logging to base.py * struct logging in run_operation * add struct logging to base * add struct logging to clean * add struct logging to debug * add struct logging to deps * fix errors * add struct logging to run.py * fixed flake error * add struct logging to geneerate * added debug level stack trace * fixed flake error * added struct logging to compile * added struct logging to freshness * cleaned up errors * resolved bug that broke everything * removed accidental import * fixed bug with unused args
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
* add struct logging to base.py * struct logging in run_operation * add struct logging to base * add struct logging to clean * add struct logging to debug * add struct logging to deps * fix errors * add struct logging to run.py * fixed flake error * add struct logging to geneerate * added debug level stack trace * fixed flake error * added struct logging to compile * added struct logging to freshness * cleaned up errors * resolved bug that broke everything * removed accidental import * fixed bug with unused args
kwigley
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add struct logging to base.py * struct logging in run_operation * add struct logging to base * add struct logging to clean * add struct logging to debug * add struct logging to deps * fix errors * add struct logging to run.py * fixed flake error * add struct logging to geneerate * added debug level stack trace * fixed flake error * added struct logging to compile * added struct logging to freshness * cleaned up errors * resolved bug that broke everything * removed accidental import * fixed bug with unused args
nathaniel-may
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add struct logging to base.py * struct logging in run_operation * add struct logging to base * add struct logging to clean * add struct logging to debug * add struct logging to deps * fix errors * add struct logging to run.py * fixed flake error * add struct logging to geneerate * added debug level stack trace * fixed flake error * added struct logging to compile * added struct logging to freshness * cleaned up errors * resolved bug that broke everything * removed accidental import * fixed bug with unused args
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* add struct logging to base.py * struct logging in run_operation * add struct logging to base * add struct logging to clean * add struct logging to debug * add struct logging to deps * fix errors * add struct logging to run.py * fixed flake error * add struct logging to geneerate * added debug level stack trace * fixed flake error * added struct logging to compile * added struct logging to freshness * cleaned up errors * resolved bug that broke everything * removed accidental import * fixed bug with unused args automatic commit by git-black, original commits: 281d249
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying call sites for structured logging in core/dbt/task
This directory has a lot of logging so splitting it up for the purposes of smaller reviews.
Checklist
CHANGELOG.md
and added information about my change