Fix comma if only removing columns in on_schema_change: sync_all_columns
#4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-christophe-oudar
approved these changes
Oct 27, 2021
Comment on lines
+13
to
+14
| select id | ||
| ,cast(field1 as {{string_type}}) as field1 |
There was a problem hiding this comment.
Nitpicking on formatting to align with other selects
Suggested change
| select id | |
| ,cast(field1 as {{string_type}}) as field1 | |
| select id, | |
| cast(field1 as {{string_type}}) as field1 |
leahwicz
approved these changes
Oct 27, 2021
jtcohen6
added a commit
that referenced
this pull request
Oct 28, 2021
…umns` (#4148) * Fix comma if only removing in on_schema_change: sync * Add changelog entry
jtcohen6
added a commit
that referenced
this pull request
Oct 28, 2021
jtcohen6
added a commit
that referenced
this pull request
Nov 8, 2021
* Add integration tests * Reorganize + dispatch more global macros * Reorg materializations subdir * Move around + document generic tests * Fix failing tests * Fix merge conflict * Grab fix from #4148 * PR feedback * Fixup * Add load_relation back, it was nice * Last few test fixes * Rm incremental_upsert, now unused * Add changelog entry
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Add integration tests * Reorganize + dispatch more global macros * Reorg materializations subdir * Move around + document generic tests * Fix failing tests * Fix merge conflict * Grab fix from #4148 * PR feedback * Fixup * Add load_relation back, it was nice * Last few test fixes * Rm incremental_upsert, now unused * Add changelog entry automatic commit by git-black, original commits: 8442fb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4147
on_schema_changeconfig for incremental models)on_schema_change, following the logic I implemented in Add support for on_schema_change dbt-spark#229Checklist
CHANGELOG.mdand added information about my change