-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error on pip install dbt
#4133
Conversation
pip install dbt
e40fd46
to
a0fa14d
Compare
I'm pretty sure this change will break PyPi metadata, so we might need to hand-roll that instead. Maybe we could test by pushing a |
@jtcohen6 we have the test PyPi account we can use to try this out |
@leahwicz ah really good thought!! I forgot all about that |
@kwigley Thanks for the magic one-liner there. I did some reorg enabled by that, including some edits to Let's try building |
Now that I've reenabled the source-only distribution of |
45de2e8
to
7ee2f18
Compare
I'm not convinced that
fulfils the "clear" component of
Why? Because I don't understand it 😅 . I'm reading it as "to access the critical functionality of dbt", but I think you want me to read it as "access the functionality of the dbt core project". Is that right? Who is the target market for dbt-core on its own? I assume it's people building things that integrate with the dbt ecosystem, as opposed to analytics engineers building a dbt project? As a generic end user, "connect to a database" is definitely " Noodling on some alternatives:
|
I like this! I'll also move it so that it's after Just opened: #4229 |
* Raise error on pip install dbt * Fix relative path logic * Do not build dist for dbt * Fix long descriptions * Trigger code checks * Using root readme more trouble than good * only fail on install, not build * Edit dist script. Avoid README duplication * jk, be less clever * Ignore 'dbt' source distribution when testing * Add changelog entry Co-authored-by: Kyle Wigley <[email protected]> automatic commit by git-black, original commits: dd84f9a
resolves #4100
pip install dbt
dbt-core
(incore/setup.py
)What's good
dbt-core
→dbt-snowflake
→dbt
)What's bad
pip install dbt
dbt
(rather thandbt-core
)pip install .
will not work, it needs to be cloning this repo +pip install -r requirements.txt
(what dbt CloudHEAD
does) orpip install -r editable-requirements.txt
(what we tell contributors to do)pip install git+https://github.com/dbt-labs/dbt-core
will not work, it needs to begit+https://github.com/dbt-labs/dbt.git#egg=dbt-core&subdirectory=core
(we can document this)Uncertainties
dbt
?Checklist
CHANGELOG.md
and added information about my change