Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4060] Refactor partial parsing test to avoid file collisions #4068

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 15, 2021

resolves #4060

Description

Fix intermittent test failures caused by simultaneous execution of the same partial parsing tests.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Gerda Shank.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@gshank
Copy link
Contributor Author

gshank commented Oct 15, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Oct 15, 2021
@cla-bot
Copy link

cla-bot bot commented Oct 15, 2021

The cla-bot has been summoned, and re-checked this pull request!

@gshank gshank force-pushed the refactor-partial-parsing-tests branch from 1ceff4c to e965d1a Compare October 15, 2021 13:59
@gshank gshank requested review from leahwicz and kwigley October 15, 2021 14:13
@kwigley kwigley added the test postgres Run integration tests for the Postgres adapter in CI. label Oct 15, 2021
@kwigley
Copy link
Contributor

kwigley commented Oct 15, 2021

Sorry for closing and re-opening, triggering integration tests.

@kwigley kwigley closed this Oct 15, 2021
@kwigley kwigley reopened this Oct 15, 2021
@gshank gshank merged commit 80ba716 into main Oct 15, 2021
@gshank gshank deleted the refactor-partial-parsing-tests branch October 15, 2021 17:54
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still 2 tests failing, I think they might be typos? Can you take a look?

https://github.com/dbt-labs/dbt-core/runs/3908916981?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes test postgres Run integration tests for the Postgres adapter in CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Integration tests that move files can fail when run in parallel
3 participants