Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build task arg parity #3884

Merged
merged 6 commits into from
Sep 16, 2021
Merged

Build task arg parity #3884

merged 6 commits into from
Sep 16, 2021

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Sep 15, 2021 •
edited
Loading

resolves #3596

Description

Adds:

  • --resource-type param to cli and rpc task
  • ensures that -models and --select are mutually exclusive (aligns with list task behavior)
    • additionally, --models will only select nodes of type model (again, to align with list task behavior)
  • adds --store-failures param to cli task

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@kwigley kwigley self-assigned this Sep 15, 2021
@kwigley kwigley force-pushed the kwigley/build-task-args branch from 26d6146 to b7390e2 Compare September 15, 2021 14:55
@cla-bot cla-bot bot added the cla:yes label Sep 15, 2021
@kwigley kwigley force-pushed the kwigley/build-task-args branch from 633bd6d to 7e5cb4a Compare September 16, 2021 14:50
@kwigley kwigley marked this pull request as ready for review September 16, 2021 14:50
jtcohen6
jtcohen6 reviewed Sep 16, 2021
View reviewed changes
core/dbt/task/build.py Outdated Show resolved Hide resolved
gshank
gshank approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kwigley kwigley merged commit d3826e6 into develop Sep 16, 2021
@kwigley kwigley deleted the kwigley/build-task-args branch September 16, 2021 20:21
@kwigley kwigley mentioned this pull request Sep 16, 2021
Merged
4 tasks
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@iknox-fa
Build task arg parity (#3884)
6303d17 
automatic commit by git-black, original commits:
  d3826e6
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@iknox-fa
Build task arg parity (#3884)
99b8ca6 
automatic commit by git-black, original commits:
  d3826e6
  d4974cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 left review comments

@gshank gshank gshank approved these changes

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

Assignees

@kwigley kwigley

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbt build: Parity for flags
3 participants
@kwigley @gshank @jtcohen6