-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ls
to RPC server
#3384
Add ls
to RPC server
#3384
Conversation
… into feature/ls_in_RPC
dc3bf14
to
1be6254
Compare
This is working well for me in local testing! A few comments:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There's one last failing test on Windows, I think because of file paths
- I confirmed that passing both
models
andselect
raises an error (good!), passing bothresource_types
params still doesn't raise the expected error ("models" and "resource_type" are mutually exclusive arguments
). This isn't the most important thing: we're thinking of retiring the--models
flag/param soon, anyway (Remove the distinction between --select and --models flags when working with node types #3210).
Once the failing test is sorted, I'm quite happy with where this is at. Nice work!
c832639
to
e68fd6e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
resolves #3311 and #3356
Description
Adds support for the
list
method in the RPC serverAdds new keys for
unique_id
andoriginal_file_path
to list task when invoked with json outputChecklist
CHANGELOG.md
and added information about my change to the "dbt next" section.