Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light cleanup of v0.19.0 changelogs #2994

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jan 7, 2021

Description

  • More eagerly record Breaking Changes, and more specificity around which particular aspects are breaking
  • Give credit to contributors on adjacent repos (Infer the node name from the unique_id dbt-adapter-tests#10)
  • If only one issue/PR was linked, include the other as well (except for a few PRs with no corresponding issues)
  • Minor opinionated moves from, e.g., Feature to Under the Hood
  • Minor reformatting: inline code, missing parentheses

Let me know if any of these goes too far, or in a direction with which you disagree ~~

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@jtcohen6 jtcohen6 requested review from gshank and kwigley January 7, 2021 09:15
@cla-bot cla-bot bot added the cla:yes label Jan 7, 2021
@jtcohen6 jtcohen6 changed the title Light cleanup of v0.19 changelogs Light cleanup of v0.19.0 changelogs Jan 7, 2021
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kwigley
Copy link
Contributor

kwigley commented Jan 7, 2021

☹️ the azure workflow looks like it is hanging. you might have to close and reopen the PR to force checks to run again? or git commit --amend and git push -f maybe?

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jan 7, 2021

Yeah... I'm just going to merge this as admin ¯\(ツ)

@jtcohen6 jtcohen6 merged commit 30f473a into dev/kiyoshi-kuromiya Jan 7, 2021
@jtcohen6 jtcohen6 deleted the copyedit-changelog branch January 7, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants