-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store relation name in manifest's node and source objects #2837
Merged
jtcohen6
merged 24 commits into
dbt-labs:dev/kiyoshi-kuromiya
from
franloza:feature/2647-relation-name-in-metadata
Nov 9, 2020
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f638a3d
Store relation name in manifest's node object
01331ed
Update CHANGELOG.md
a0370a6
Add relation_name to node object in docs generation tests
244d5d2
Merge remote-tracking branch 'upstream/dev/kiyoshi-kuromiya' into dev…
a8809ba
Merge branch 'dev/kiyoshi-kuromiya' into feature/2647-relation-name-i…
40370e1
Fix wrong schema name in test and add missing relation_name in node
7ee78e8
Add missing relation_name fields in doc generation test manifests
c3bf0f8
Add relation_name to missing tests in test_docs_generate
b079545
Adapt relation_name for Bigquery and Snowflake in docs generation tests
c9e01bc
Fix quotes in relation name for Bigquery docs generate tests
09c37f5
Adapt relation_name to expected_run_results parameters
900298b
Fix database name in relation_name in expected_run_results
4203985
Adapt expected_seeded_manifest method to Snowflake identifier quoting
e1097f1
Define relation_name only for non-ephemeral models, seeds and snapshots
92cedf8
Fix Flake8 style issue
52ed4aa
Fix tests which are missing snapshot nodes
7115d86
Modify snapshot path for docs generation tests
a9901c4
Disable snapshot documentation testing for Redshift and Bigquery
6251d19
Use is_ephemeral_model property instead of config.materialized
franloza 784616e
Add relation name to source object in manifest
3e5d901
Add snapshot to additional Redshift and Bigquery manifest tests
21fd75b
Fix parent_map object in tests
852990e
Fix child_map in tests
b741679
Add missing key to child map in expected_bigquery_complex_manifest
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
test/integration/029_docs_generate_tests/snapshot/snapshot_seed.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{% snapshot snapshot_seed %} | ||
{{ | ||
config( | ||
unique_key='id', | ||
strategy='check', | ||
check_cols='all', | ||
target_schema=var('alternate_schema') | ||
) | ||
}} | ||
select * from {{ ref('seed') }} | ||
{% endsnapshot %} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍