Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves part of #2302
Description
This ports
adapter_macro
to python, which involved some cleanup of the node selection logic.I split the macros and manifest+query header contexts out from the
configured
context as that file was getting too busy.I made no change to actual behavior, so the real test here is that all the existing integration tests pass.
I added a
get_adapter_type_names
to the adapter factory to handle an inheritance-style lookup, but that looked like it broke things. I rolled that back but would like to keep the adapter factory changes as I think they're probably for the best.In the future, we should consider changing it so redshift automatically tries the postgres version of a macro when there's no redshift version before falling back to the default, but let's keep the breaking changes to a minimum for now.
A future PR will implement the
dispatch
name and additional arguments.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.