-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bq incremental strategy insert_overwrite #2153
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
test/integration/022_bigquery_test/data/incremental_overwrite_expected.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
id,date_day | ||
10,2020-01-01 | ||
20,2020-01-01 | ||
30,2020-01-02 | ||
40,2020-01-02 |
36 changes: 36 additions & 0 deletions
36
test/integration/022_bigquery_test/scripting-models/incremental_overwrite.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
|
||
{{ | ||
config( | ||
materialized="incremental", | ||
incremental_strategy='insert_overwrite', | ||
cluster_by="id", | ||
partition_by={ | ||
"field": "date_day", | ||
"data_type": "date" | ||
} | ||
) | ||
}} | ||
|
||
|
||
with data as ( | ||
select 1 as id, cast('2020-01-01' as date) as date_day union all | ||
select 2 as id, cast('2020-01-01' as date) as date_day union all | ||
select 3 as id, cast('2020-01-01' as date) as date_day union all | ||
select 4 as id, cast('2020-01-01' as date) as date_day | ||
|
||
{% if is_incremental() %} | ||
union all | ||
-- we want to overwrite the 4 records in the 2020-01-01 partition | ||
-- with the 2 records below, but add two more in the 2020-01-01 partition | ||
select 10 as id, cast('2020-01-01' as date) as date_day union all | ||
select 20 as id, cast('2020-01-01' as date) as date_day union all | ||
select 30 as id, cast('2020-01-02' as date) as date_day union all | ||
select 40 as id, cast('2020-01-02' as date) as date_day | ||
{% endif %} | ||
) | ||
|
||
select * from data | ||
|
||
{% if is_incremental() %} | ||
where ts >= _dbt_max_partition | ||
{% endif %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could live 1,000 more years and i would still not understand this DML...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have lived 2 days and I have read the documentation, and I now understand this DML.
The key thing I was missing:
when not matched by source
is always true here because we're using a constant-false predicate. I was errantly thinking that we were still merging on aunique_key
, which we are not.From the docs:
Cool!