-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 0.14.1 into louisa-may-alcott #1668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `information_schema` in Postgres is not very performant due to the complex views used to create it - use underlying `pg_catalog` tables/views instead - returns the same rows/columns as the `information_schema` version - order of rows is different, this is because there was only a partial sort on the `information_schema` version - `column_type` will return different values to before - some arrays were `ARRAY`, will now be `type[]` - user-defined types were previously `USER_DEFINED`, now will be the name of the user-defined type <-- main point of this PR - performance is 2-5x faster, depending on query caching
v = view r, f, p = all are different forms of table
…e-application-name Set application name in snowflake connections
…ols-cycle possible fix for re-used check cols on BQ
…scription-interpolation Fix for unrendered source column descriptions
…ks-flag Add environment variables for macro debugging flags (#1628)
Co-Authored-By: Drew Banin <[email protected]>
…ss-disable add test for nulled out freshness spec
…ection exclude ephemeral addins in dbt ls command
…rd-execute (#1626) fix for RPC error with BQ nested fields
In Postgres, rollbacks can fail if the transaction was killed by the database. One common scenario is that the `idle_in_transaction_session_timeout` is enabled. If the transaction was cancelled, the connection is left open in `dbt`. `dbt` attempts to close that connection after issuing a `ROLLBACK`. But it fails since the transaction was severed. Since the cleanup is carried out in a `finally` statement, the `psycopg2.InternalDatabaseError` is thrown and prevents the test case results from ever being shown. Changes here wrap the `ROLLBACK` in a try-catch such that if there is an exception thrown, it is logged appropriately, but ultimately proceeds.
Fix for unicode chars in seed files
…nup-rollbacks Log, but allow, failures during cleanup rollbacks.
(#1597) summarize warnings at end of test invocations
updated dbt.exceptions reference to exceptions in .sql files
(#1645) fix for errant cookie generation
bump docs site to 0.14.1
Change postgres `get_catalog` to not use `information_schema`
Fix typo "paramteter" -> "parameter"
Update CHANGELOG.md
…ture-templates GitHub issue / PR touchups
…-old-pg-versions (#1665) Fix for casting error on old versions of postgres in snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge was not very pretty and I'd like to know the Windows tests pass before I merge it into louisa-may-alcott.