Fix postgres text handling (#781) #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2019 13:50
Fix incorrect maximum text field length on redshift On postgres, pass through text without size information to fix archival of long text fields Add a test that makes sure postgres archives work with very long text entries Fix tests Add a redshift test
beckjake
force-pushed
the
fix/postgres-text-types
branch
from
6f8ae46 to
08fdcad
Compare
drewbanin
reviewed
Apr 30, 2019
| from dbt.logger import GLOBAL_LOGGER as logger # noqa | ||
|
|
||
|
|
||
| class RedshiftAdapter(PostgresAdapter): | ||
| ConnectionManager = RedshiftConnectionManager | ||
| # postgres overrides this, so override the override. | ||
| Column = Column |
There was a problem hiding this comment.
Is there any merit to making a RedshiftColumn type that just inherits from Column? I think that might be a little more clear that the override override
There was a problem hiding this comment.
Yeah, I think that's totally reasonable.
|
|
||
| insert into {database}.{schema}.super_long (id, longstring, updated_at) VALUES | ||
| (1, 'short', current_timestamp), | ||
| (2, repeat('a', 500), current_timestamp); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781
Fix incorrect maximum text field length on redshift (255 -> 256)
On postgres, pass through text without size information to fix archival of long text fields
Add a test that makes sure archives work with very long text entries on postgres