Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presto notimplemented errors (#1228) #1246

Merged
merged 2 commits into from
Jan 23, 2019
Merged

presto notimplemented errors (#1228) #1246

merged 2 commits into from
Jan 23, 2019

Conversation

beckjake
Copy link
Contributor

Resolves #1228

Note: This is against the feature/presto-adapter branch (#1245), not dev/stephen-girard.

  • Make archives on presto print 'not implemented' errors and exit instead of running invalid SQL.
  • Add tests that ensure archives/incremental models on presto fail with proper errors.

drewbanin
drewbanin approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckjake beckjake changed the base branch from feature/presto-adapter to dev/stephen-girard January 23, 2019 18:18
@beckjake beckjake merged commit cdeb0d1 into dev/stephen-girard Jan 23, 2019
@beckjake beckjake deleted the feature/presto-notimplemented-error branch January 23, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckjake @drewbanin