Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move initialization of keyword_args up #11188

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jan 6, 2025

Resolves #

Problem

    checker(removed_node, None, **keyword_args)  # type: ignore
                                  ^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'keyword_args' where it is not associated with a value

Solution

Move up initialization of keyword_args

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner January 6, 2025 18:08
@cla-bot cla-bot bot added the cla:yes label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (0bf38ce) to head (5429c22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11188      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files         187      187              
  Lines       24057    24057              
==========================================
- Hits        21395    21393       -2     
- Misses       2662     2664       +2     
Flag Coverage Δ
integration 86.30% <100.00%> (-0.03%) ⬇️
unit 62.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.05% <100.00%> (ø)
Integration Tests 86.30% <100.00%> (-0.03%) ⬇️

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Jan 6, 2025
@gshank gshank merged commit 7106005 into main Jan 6, 2025
66 of 68 checks passed
@gshank gshank deleted the fix_selector_methods_kwarg branch January 6, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants