-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: partial parsing - reparse downstream nodes when adding versioning #11184
Conversation
…reams of newly versioned models are parsed.
…hedule_referencing_nodes_for_parsing call instead of files returned.
…t added to a model. More info: dbt-labs#8872
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11184 +/- ##
==========================================
- Coverage 88.93% 86.17% -2.76%
==========================================
Files 186 187 +1
Lines 24054 24059 +5
==========================================
- Hits 21392 20733 -659
- Misses 2662 3326 +664
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix and tests look great, thanks for contributing this fix! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves # #8872
Problem
Adding versioning to a model with dependencies requires a full-parse. See workaround.
Solution
Schedule referencing nodes for parsing if the model in the new schema file is versioned (here).
Reviewer Questions
delete_schema_mssa_links
but I ignored hints on the assignments to avoid including a larger refactor in this PR. Is there a preference for how type changes like this are handled? I see a mix of blanket ignores and type specific ignores (e.g.# type: ignore[assignment]
).Checklist