Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #10526 #10567

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Backport #10526 #10567

merged 1 commit into from
Aug 15, 2024

Conversation

peterallenwebb
Copy link
Contributor

Resolves #10434

Backports #10526

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

* update children search

* update search to include children in original selector

* add changie

* remove unused function

* fix wrong function call

* fix depth
@peterallenwebb peterallenwebb requested a review from a team as a code owner August 14, 2024 21:21
@cla-bot cla-bot bot added the cla:yes label Aug 14, 2024
@peterallenwebb peterallenwebb changed the base branch from main to 1.8.latest August 14, 2024 21:23
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (8ee5788) to head (49b80aa).
Report is 1 commits behind head on 1.8.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10567      +/-   ##
==============================================
- Coverage       88.32%   88.32%   -0.01%     
==============================================
  Files             181      181              
  Lines           22779    22793      +14     
==============================================
+ Hits            20119    20131      +12     
- Misses           2660     2662       +2     
Flag Coverage Δ
integration 85.57% <100.00%> (-0.01%) ⬇️
unit 62.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb merged commit 75b956b into 1.8.latest Aug 15, 2024
67 checks passed
@peterallenwebb peterallenwebb deleted the paw/backport-10526 branch August 15, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] 1.8.2 slower to build than 1.5.9 when tag+ includes many nodes
3 participants