[CT-3071] [Bug] failed to resolve schema version

[qrtt1]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The latest get_manifest_schema_version will get wrong versions and drop the metrics data:

https://github.com/dbt-labs/dbt-core/blob/v1.6.1/core/dbt/contracts/graph/manifest.py

def get_manifest_schema_version(dct: dict) -> int:
    schema_version = dct.get("metadata", {}).get("dbt_schema_version", None)
    if not schema_version:
        raise ValueError("Manifest doesn't have schema version")
    return int(schema_version.split(".")[-2][-1])

This input will get 0

https://schemas.getdbt.com/dbt/manifest/v10.json

And it will make scheam upgrader to drop metrics data
https://github.com/dbt-labs/dbt-core/blob/v1.6.1/core/dbt/contracts/graph/manifest_upgrade.py#L65-L69

def upgrade_manifest_json(manifest: dict, manifest_schema_version: int) -> dict:
    # this should remain 9 while the check in `upgrade_schema_version` may change
    if manifest_schema_version <= 9:
        drop_v9_and_prior_metrics(manifest=manifest)
   ...

Expected Behavior

The metrics data should be kept

Steps To Reproduce

1. use the dbt 1.6 project with metrics (https://github.com/InfuseAI/jaffle-sl-template)
2. create the state directory dbt parse --target-path baseline
3. modify some metrics criteria
4. select modified and nothing selected dbt list -s 'state:modified' --state baseline

Relevant log output

No response

Environment

- OS: OSX
- Python: 3.10.6
- dbt:


Core:
  - installed: 1.6.1
  - latest:    1.6.1 - Up to date!

Plugins:
  - snowflake: 1.6.1 - Update available!
  - duckdb:    1.6.0 - Up to date!

  At least one plugin is out of date or incompatible with dbt-core.
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

### Which database adapter are you using with dbt?

other (mention it in "Additional Context")

### Additional Context

_No response_

[jtcohen6]

@qrtt1 Thanks for opening! This is definitely a bug, and one we should resolve quickly, since it will affect anyone who's upgrading to v1.6.

This is a naive fix:

import re
...
def get_manifest_schema_version(dct: dict) -> int:
    schema_version = dct.get("metadata", {}).get("dbt_schema_version", None)
    if not schema_version:
        raise ValueError("Manifest doesn't have schema version")
    match_str = "v([0-9]+)"
    return int(re.search(match_str, schema_version).groups()[0])

>>> schema_version = "https://schemas.getdbt.com/dbt/manifest/v10.json"
>>> match_str = "v([0-9]+)"
>>> int(re.search(match_str, schema_version).groups()[0])
10

We should also figure out why this errant behavior wasn't being caught in our test for manifest version upgrades / backward compatibility: https://github.com/dbt-labs/dbt-core/blob/main/tests/functional/artifacts/test_previous_version_state.py

[aranke]

I'm able to replicate this issue and updated the test case to fail: #8551.

I'll now work on updating the code to make the test case pass.