-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2846] Update dependency pins: click<9
+ sqlparse<0.5
#8145
Labels
dependencies
Changes to the version of dbt dependencies
tech_debt
Behind-the-scenes changes, with little direct impact on end-user functionality
Comments
jtcohen6
added
dependencies
Changes to the version of dbt dependencies
tech_debt
Behind-the-scenes changes, with little direct impact on end-user functionality
labels
Jul 19, 2023
github-actions
bot
changed the title
Update dependency pins:
[CT-2846] Update dependency pins: Jul 19, 2023
click<9
+ sqlparse<0.5
click<9
+ sqlparse<0.5
4 tasks
Looks like there are still some issues with |
This was referenced Jul 27, 2023
Merged
I don't know why these are combined. sqlparse can get an upper bound without any issues so I split it out to #8236. |
opening up the pin for click does still have some mypy failures. specifically these just 3 in #8232. Question is if we want to ignore them or just not upgrade yet.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Changes to the version of dbt dependencies
tech_debt
Behind-the-scenes changes, with little direct impact on end-user functionality
Unpin
click
now that a new version has been released that should fix the typing issues:click==8.1.4
from dependencies #8048We removed the
sqlparse
pin in #7993 — but we should still have an upper bound since it's major-0 software. Previously we had the upper bound pinned to<0.5
.We should backport to
1.6.latest
(for inclusion in v1.6.0rc2/final) +1.5.latest
(for inclusion in v1.5.4)The text was updated successfully, but these errors were encountered: