Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2846] Update dependency pins: click<9 + sqlparse<0.5 #8145

Closed
jtcohen6 opened this issue Jul 19, 2023 · 3 comments · Fixed by #8232 or #8236
Closed

[CT-2846] Update dependency pins: click<9 + sqlparse<0.5 #8145

jtcohen6 opened this issue Jul 19, 2023 · 3 comments · Fixed by #8232 or #8236
Assignees
Labels
dependencies Changes to the version of dbt dependencies tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 19, 2023

Unpin click now that a new version has been released that should fix the typing issues:


We removed the sqlparse pin in #7993 — but we should still have an upper bound since it's major-0 software. Previously we had the upper bound pinned to <0.5.


We should backport to 1.6.latest (for inclusion in v1.6.0rc2/final) + 1.5.latest (for inclusion in v1.5.4)

@jtcohen6 jtcohen6 added dependencies Changes to the version of dbt dependencies tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Jul 19, 2023
@github-actions github-actions bot changed the title Update dependency pins: click<9 + sqlparse<0.5 [CT-2846] Update dependency pins: click<9 + sqlparse<0.5 Jul 19, 2023
@jtcohen6
Copy link
Contributor Author

Looks like there are still some issues with mypy + click==8.1.6: #8146 (comment)

@emmyoop
Copy link
Member

emmyoop commented Jul 27, 2023

I don't know why these are combined. sqlparse can get an upper bound without any issues so I split it out to #8236.

@emmyoop
Copy link
Member

emmyoop commented Jul 27, 2023

opening up the pin for click does still have some mypy failures. specifically these just 3 in #8232. Question is if we want to ignore them or just not upgrade yet.

core/dbt/cli/params.py:392: error: Argument 2 to "option" has incompatible type "**Dict[str, Union[Type[Tuple[Any, ...]], bool, Type[MultiOption], str, None]]"; expected "Optional[Type[Option]]"  [arg-type]
core/dbt/cli/params.py:393: error: Argument 2 to "option" has incompatible type "**Dict[str, Union[Type[Tuple[Any, ...]], bool, Type[MultiOption], str, None]]"; expected "Optional[Type[Option]]"  [arg-type]
core/dbt/cli/params.py:394: error: Argument 3 to "option" has incompatible type "**Dict[str, Union[Type[Tuple[Any, ...]], bool, Type[MultiOption], str, None]]"; expected "Optional[Type[Option]]"  [arg-type]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the version of dbt dependencies tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
3 participants