Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2804] Exclude click==8.1.4 from dependencies #8048

Closed
QMalcolm opened this issue Jul 7, 2023 · 0 comments · Fixed by #8050
Closed

[CT-2804] Exclude click==8.1.4 from dependencies #8048

QMalcolm opened this issue Jul 7, 2023 · 0 comments · Fixed by #8050
Assignees
Labels
bug Something isn't working dependencies Changes to the version of dbt dependencies

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jul 7, 2023

Problem

When click==8.1.4 was released, our code quality workflows using mypy began failing. An issue has been created on the click repository.

Solution

The solution is to exclude, for the time being, click==8.1.4. Currently our click dependency is set to click>=7.0,<9.0, this should become on main click>=8.1.1,<8.1.4.

Backports

We need to backport this fix to 1.3.latest, 1.4.latest, and 1.5.latest. For the backports we should update the dependency from click>=7.0,<9.0 to click>=7.0,<8.1.4. The reason for the different specification in the backports is that we already support click 7.x in these earlier versions. Dropping support for click 7.x could be problematic if people are installing dbt-core alongside other dependencies which limit click to 7.x., then dropping support for click 7.x would represent a breaking change (and we shouldn't do this in a patch version).

@QMalcolm QMalcolm added bug Something isn't working dependencies Changes to the version of dbt dependencies labels Jul 7, 2023
@github-actions github-actions bot changed the title Exclude click==8.1.4 from dependencies [CT-2804] Exclude click==8.1.4 from dependencies Jul 7, 2023
@emmyoop emmyoop mentioned this issue Jul 7, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Changes to the version of dbt dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants