Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2717] Disallow conditional configuration (Jinja-in-yaml rendering) within dependencies.yml #7905

Closed
Tracked by #7372
jtcohen6 opened this issue Jun 20, 2023 · 0 comments · Fixed by #7910
Closed
Tracked by #7372

[CT-2717] Disallow conditional configuration (Jinja-in-yaml rendering) within dependencies.yml #7905

jtcohen6 opened this issue Jun 20, 2023 · 0 comments · Fixed by #7910
Assignees
@gshank
Labels
multi_project tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@jtcohen6
Copy link
Contributor

Follow-up to #7857

As described in #7631 (comment), we do not want to allow conditional configuration of projects and packages within dependencies.yml (i.e. Jinja-in-yaml rendering). I foresee this making it much trickier to parse this configuration outside of dbt-core, and it significantly expands the complexity of use cases we'll need to support in the future.

To avoid breaking changes for existing users & use cases, we should continue to support conditional configuration of packages if (and onlyif) defined in the old file name, packages.yml.
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality multi_project labels Jun 20, 2023
@github-actions github-actions bot changed the title Disallow conditional configuration (Jinja-in-yaml rendering) within dependencies.yml [CT-2717] Disallow conditional configuration (Jinja-in-yaml rendering) within dependencies.yml Jun 20, 2023
@jtcohen6 jtcohen6 mentioned this issue Jun 20, 2023
Closed
@gshank gshank self-assigned this Jun 20, 2023
@gshank gshank mentioned this issue Jun 20, 2023
Merged
6 tasks
@jeremyyeo jeremyyeo mentioned this issue Oct 10, 2023
Merged
2 tasks
mirnawong1 added a commit to dbt-labs/docs.getdbt.com that referenced this issue Oct 11, 2023
@mirnawong1
Update project-dependencies.md (#4247)
6edeee9 
## What are you changing in this pull request and why?
We don't allow private packages via Git Token to be defined in the
`dependencies.yml` file so we should call it out for clarity.

dbt-labs/dbt-core#7905

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
multi_project tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not jinja render packages from dependencies yml dbt-labs/dbt-core
2 participants
@gshank @jtcohen6