[CT-25] [Bug] dbt deps should not require a profile

[olivierdet]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

We have defined a profile like that :

    prod:
      type: redshift
      threads: "{{ env_var('DBT_THREADS', 1)| int }}"
      host: "{{ env_var('REDSHIFT_HOST') }}"
      port: 5439
      user: "{{ env_var('REDSHIFT_USER') }}"
      pass: "{{ env_var('REDSHIFT_PASSWORD') }}"
      dbname: "{{ env_var('REDSHIFT_DATABASE') }}"
      schema: "bi"

If one of the env is not defined ( ex : REDSHIFT_DATABASE) we now have the following error message while running dbt deps

13:26:05  Encountered an error:
Parsing Error
  Env var required but not provided: 'REDSHIFT_DATABASE'

If it is defined with a dummy data, it works properly. ( So it does not check connection)

Expected Behavior

dbt depsshould not return any issue when a env variable is not defined.

Steps To Reproduce

1. Define a profile with env variable
2. Do not define the given env variable
3. run dbt deps

Relevant log output

No response

Environment

- OS:container python:3.9.6-slim-buster
- Python: 3.9.6
- dbt:1.0.0

What database are you using dbt with?

redshift

Additional Context

No response

[gshank]

When you say "we now have the following error message", do you mean that this used to work? In what version? A quick glance at the code shows that throwing an error for a missing env_var is not new to 1.0.0.

I think the ability to set a default for the env_var, like you do for DBT_THREADS, is designed for this case. You could do env_var('REDSHIFT_DATABASE, '').

[olivierdet]

Hello, it was working perfectly for the version before the 1.0.0.
We are using this logic for in the version 0.21.1 (and before also)
This bug is seen when we try to move to version 1.0.0

[gshank]

This bug is due to changing the env_var exception to a parsing exception, so that the exception is not caught in _get_rendered_profile in core/dbt/config/runtime.py. The error that is issued in 0.21 is not correct however, and this is not a good way to handle suppressing profile errors because the final error reported is not correct.

This should be fixed, however, since we should not need to load a profile for the dbt deps command.

[leahwicz]

We should also check dbt clean and dbt debug