Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tagging of sources, not just models #1906

Closed
mferryRV opened this issue Nov 8, 2019 · 3 comments
Closed

Enable tagging of sources, not just models #1906

mferryRV opened this issue Nov 8, 2019 · 3 comments
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@mferryRV
Copy link

mferryRV commented Nov 8, 2019

Describe the feature

Allow tagging of sources, similar to tagging of models.

Describe alternatives you've considered

The primary use case for tagging in sources as well as models is to isolate a set of transformations soup-to-nuts. When I do a bunch of work on, say, email data, I want to show people the sources, transformations, and outputs I created. I can do that for one source with DAG commands like source:braze_segment+
image

But what about when I add Responsys? Mandrill? Now I have multiple sources and I can't display them all at once. I'd need to pick a downstream table and show all the upstream dependencies, but what if some of my source tables aren't being used yet?

It would be easier if I could just tag source tables as related to my models & display this full process for my teammates to understand the work I've done.

Additional context

This use case is primarily aimed at dbt docs functionality, so changes in the flexibility of the Lineage Graph might make this less necessary.

Who will this benefit?

Anyone trying to onboard someone to a new dataset would benefit from the ability to show everything at their disposal.

@mferryRV mferryRV added enhancement New feature or request triage labels Nov 8, 2019
@drewbanin drewbanin removed the triage label Nov 8, 2019
@drewbanin drewbanin added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Nov 17, 2019
@drewbanin drewbanin added this to the 0.15.2: Barbara Gittings milestone Nov 17, 2019
@drewbanin
Copy link
Contributor

Yep! Great idea - let's do it :)

There are a couple of semi-related issues here that i think we should consider here too:

@mferryRV
Copy link
Author

mferryRV commented Nov 19, 2019

Stoked to see this prioritised!

For the curious users seeking a stop gap, you can highlight multiple sections of the docs Lineage Graph by putting a space between the commands, e.g. source:my_source_1+ source:my_source_2+ like so:
image

Not quite as flexible as tagging, but still useful!

@beckjake
Copy link
Contributor

beckjake commented Feb 4, 2020

This is fixed in #2039

@beckjake beckjake closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

No branches or pull requests

3 participants