Add unique_id to CompiledNode and ShowNode logging events (#7308)

dbt-labs · Apr 10, 2023 · f38d5ad · f38d5ad
1 parent 7e1f04c
commit f38d5ad
Show file tree

Hide file tree

Showing 6 changed files with 218 additions and 208 deletions.
diff --git a/.changes/unreleased/Under the Hood-20230410-140228.yaml b/.changes/unreleased/Under the Hood-20230410-140228.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Add unique_id to ShowNode and CompiledNode logging events
+time: 2023-04-10T14:02:28.86602-04:00
+custom:
+  Author: gshank
+  Issue: "7305"
diff --git a/core/dbt/events/types.proto b/core/dbt/events/types.proto
@@ -1780,6 +1780,7 @@ message ShowNode {
     string preview = 2;
     bool is_inline = 3;
     string output_format = 4;
+    string unique_id = 5;
 }
 
 message ShowNodeMsg {
@@ -1793,6 +1794,7 @@ message CompiledNode {
     string compiled = 2;
     bool is_inline = 3;
     string output_format = 4;
+    string unique_id = 5;
 }
 
 message CompiledNodeMsg {

diff --git a/core/dbt/events/types_pb2.py b/core/dbt/events/types_pb2.py
diff --git a/core/dbt/task/compile.py b/core/dbt/task/compile.py
@@ -88,6 +88,7 @@ def task_end_messages(self, results):
                     compiled=result.node.compiled_code,
                     is_inline=is_inline,
                     output_format=output_format,
+                    unique_id=result.node.unique_id,
                 )
             )
 

diff --git a/core/dbt/task/show.py b/core/dbt/task/show.py
@@ -81,6 +81,7 @@ def task_end_messages(self, results):
                     preview=output.getvalue(),
                     is_inline=is_inline,
                     output_format=self.args.output,
+                    unique_id=result.node.unique_id,
                 )
             )
 

diff --git a/tests/unit/test_events.py b/tests/unit/test_events.py
@@ -334,8 +334,8 @@ def test_event_codes(self):
     types.CommandCompleted(
         command="", success=True, elapsed=0.1, completed_at=get_json_string_utcnow()
     ),
-    types.ShowNode(node_name="", preview="", is_inline=True),
-    types.CompiledNode(node_name="", compiled="", is_inline=True),
+    types.ShowNode(node_name="", preview="", is_inline=True, unique_id="model.test.my_model"),
+    types.CompiledNode(node_name="", compiled="", is_inline=True, unique_id="model.test.my_model"),
     # W - Node testing ======================
     types.CatchableExceptionOnRun(exc=""),
     types.InternalErrorOnRun(build_path="", exc=""),