Skip to content

Commit

Permalink
clean up replace() calls
Browse files Browse the repository at this point in the history
  • Loading branch information
Jacob Beck committed May 20, 2020
1 parent fcf57a5 commit e36fb3c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions core/dbt/contracts/graph/model_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,9 @@ def update_from(
return self.from_dict(dct, validate=validate)

def finalize_and_validate(self: T) -> T:
self.to_dict(validate=True)
return self.replace()
# from_dict will validate for us
dct = self.to_dict(omit_none=False, validate=False)
return self.from_dict(dct)


@dataclass
Expand Down

0 comments on commit e36fb3c

Please sign in to comment.