loosen the click pin (#8232) (#8249)

* loosen the click pin * changelog * separate out sqlparse pin * remove changelog * add ignores (cherry picked from commit 5b6d21d) Co-authored-by: Emily Rockman <[email protected]>
dbt-labs · Jul 28, 2023 · b4751c8 · b4751c8
1 parent ec50a94
commit b4751c8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.changes/unreleased/Dependencies-20230727-145703.yaml b/.changes/unreleased/Dependencies-20230727-145703.yaml
@@ -0,0 +1,6 @@
+kind: Dependencies
+body: Update pin for click<9
+time: 2023-07-27T14:57:03.180458-05:00
+custom:
+  Author: emmyoop
+  PR: "8232"
diff --git a/core/dbt/cli/params.py b/core/dbt/cli/params.py
@@ -389,9 +389,9 @@
 # Most CLI arguments should use the combined `select` option that aliases `--models` to `--select`.
 # However, if you need to split out these separators (like `dbt ls`), use the `models` and `raw_select` options instead.
 # See https://github.com/dbt-labs/dbt-core/pull/6774#issuecomment-1408476095 for more info.
-models = click.option(*model_decls, **select_attrs)
-raw_select = click.option(*select_decls, **select_attrs)
-select = click.option(*select_decls, *model_decls, **select_attrs)
+models = click.option(*model_decls, **select_attrs)  # type: ignore[arg-type]
+raw_select = click.option(*select_decls, **select_attrs)  # type: ignore[arg-type]
+select = click.option(*select_decls, *model_decls, **select_attrs)  # type: ignore[arg-type]
 
 selector = click.option(
     "--selector",

diff --git a/core/setup.py b/core/setup.py
@@ -59,8 +59,7 @@
         # ----
         # dbt-core uses these packages in standard ways. Pin to the major version, and check compatibility
         # with major versions in each new minor version of dbt-core.
-        # temporarily pinning click for mypy failures: https://github.com/pallets/click/issues/2558
-        "click>=8.1.1,<8.1.4",
+        "click<9",
         "networkx>=2.3,<4",
         # ----
         # These packages are major-version-0. Keep upper bounds on upcoming minor versions (which could have breaking changes)