Remove create_metric as a public facing SemanticModel.Measure pro…

…perty (#8068)

* Remove `create_metric` as a public facing `SemanticModel.Measure` property

We want to add `create_metric`. The `create_metric` property will be
incredibly useful. However, at this time it is not hooked up, and we don't
have time to hook it up before the code freeze for 1.6.0rc of core. As
it doesn't do anything, we shouldn't allow people to specify it, because
it won't do what one would expect. We plan on making the implementation
of `create_metric` a priority for 1.7 of core

* Changie doc for the removal of create_metric property

.changes/unreleased/Fixes-20230711-083213.yaml

@@ -0,0 +1,7 @@
+kind: Fixes
+body: Remove `create_metric` as a `SemanticModel.Measure` property because it currently
+  doesn't do anything
+time: 2023-07-11T08:32:13.158779-07:00
+custom:
+  Author: QMalcolm
+  Issue: "8064"

core/dbt/contracts/graph/unparsed.py

@@ -697,7 +697,6 @@ class UnparsedMeasure(dbtClassMixin):
     name: str
     agg: str  # actually an enum
     description: Optional[str] = None
-    create_metric: bool = False
     expr: Optional[Union[str, bool, int]] = None
     agg_params: Optional[MeasureAggregationParameters] = None
     non_additive_dimension: Optional[UnparsedNonAdditiveDimension] = None

core/dbt/parser/schema_yaml_readers.py

@@ -499,7 +499,6 @@ def _get_measures(self, unparsed_measures: List[UnparsedMeasure]) -> List[Measur
                     name=unparsed.name,
                     agg=AggregationType(unparsed.agg),
                     description=unparsed.description,
-                    create_metric=unparsed.create_metric,
                     expr=str(unparsed.expr) if unparsed.expr is not None else None,
                     agg_params=unparsed.agg_params,
                     non_additive_dimension=self._get_non_additive_dimension(