Make database/schema mandatory for all credentials

dbt-labs · Aug 6, 2019 · 60f66fc · 60f66fc
1 parent 4faa633
commit 60f66fc
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/core/dbt/adapters/base/connections.py b/core/dbt/adapters/base/connections.py
@@ -22,6 +22,8 @@ class Credentials(
     Replaceable,
     metaclass=abc.ABCMeta
 ):
+    database: str
+    schema: str
     _ALIASES: ClassVar[Dict[str, str]] = field(default={}, init=False)
 
     @abc.abstractproperty

diff --git a/plugins/bigquery/dbt/adapters/bigquery/connections.py b/plugins/bigquery/dbt/adapters/bigquery/connections.py
@@ -26,8 +26,6 @@ class BigQueryConnectionMethod(StrEnum):
 @dataclass
 class BigQueryCredentials(Credentials):
     method: BigQueryConnectionMethod
-    database: str
-    schema: str
     keyfile: Optional[str] = None
     keyfile_json: Optional[Dict[str, Any]] = None
     timeout_seconds: Optional[int] = 300

diff --git a/plugins/postgres/dbt/adapters/postgres/connections.py b/plugins/postgres/dbt/adapters/postgres/connections.py
@@ -14,12 +14,10 @@
 
 @dataclass
 class PostgresCredentials(Credentials):
-    database: str
     host: str
     user: str
     password: str
     port: Port
-    schema: str
     search_path: Optional[str]
     keepalives_idle: Optional[int] = 0  # 0 means to use the default value
 

diff --git a/plugins/snowflake/dbt/adapters/snowflake/connections.py b/plugins/snowflake/dbt/adapters/snowflake/connections.py
@@ -20,8 +20,6 @@
 class SnowflakeCredentials(Credentials):
     account: str
     user: str
-    database: str
-    schema: str
     warehouse: Optional[str]
     role: Optional[str]
     password: Optional[str]