regression: disabled models can ref other disabled models (#305)

dbt-labs · Mar 3, 2017 · 46912a8 · 46912a8
1 parent 12b0b55
commit 46912a8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/dbt/compilation.py b/dbt/compilation.py
@@ -224,8 +224,8 @@ def do_ref(*args):
 
             target_model_id = target_model.get('unique_id')
 
-            if target_model.get('config', {}) \
-                           .get('enabled') is False:
+            if target_model.get('config', {}).get('enabled') is False and \
+               model.get('config', {}).get('enabled') is True:
                 compiler_error(
                     model,
                     "Model '{}' depends on model '{}' which is disabled in "

diff --git a/test/integration/006_simple_dependency_test/models/disabled_one.sql b/test/integration/006_simple_dependency_test/models/disabled_one.sql
@@ -0,0 +1,3 @@
+{{config(enabled=False)}}
+
+select 1
diff --git a/test/integration/006_simple_dependency_test/models/disabled_two.sql b/test/integration/006_simple_dependency_test/models/disabled_two.sql
@@ -0,0 +1,3 @@
+{{config(enabled=False)}}
+
+select * from {{ref('disabled_one')}}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		{{config(enabled=False)}}

		select * from {{ref('disabled_one')}}