Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAP-400: Support materialized views with create/drop functionality #639

Merged
merged 76 commits into from
Sep 13, 2023
Merged

ADAP-400: Support materialized views with create/drop functionality #639

merged 76 commits into from
Sep 13, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Mar 30, 2023 •
edited
Loading

resolves dbt-labs/dbt-core#6911

Description

Stub out the materialized view materialization for Redshift. Under the hood this just creates a view for now. But this can be used to verify all of the plumbing.

While creating the materialization, it was observed that other materialization templates existed outside of the materialization directory. These were moved from adapters.sql into the materialization directory in the appropriate file (e.g. table.sql). Some of the macros were also refactored to be smaller bits of code and dbt-postgres dependencies were eliminated when found.

Checklist

@cla-bot cla-bot bot added the cla:yes label Mar 30, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Mar 30, 2023
@mikealfare mikealfare added this to the 1.5.0 milestone Mar 30, 2023
@mikealfare mikealfare changed the title ADAP-400: Stub materialized view as a materialization ADAP-400: Support materialized views with create/drop functionality Aug 29, 2023
@mikealfare mikealfare removed the Skip Changelog Skips GHA to check for changelog file label Aug 29, 2023
Base automatically changed from feature/materialized-views/adap-842 to main August 31, 2023 15:10
@mikealfare mikealfare marked this pull request as ready for review August 31, 2023 20:24
@mikealfare mikealfare requested a review from a team as a code owner August 31, 2023 20:24
@mikealfare mikealfare removed this from the 1.5.0 milestone Sep 11, 2023
McKnight-42
McKnight-42 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is at the end state me and Mike worked toward two weeks ago and put in line for the mergers of initial prs on remaining work.

@McKnight-42 McKnight-42 merged commit ffe2175 into main Sep 13, 2023
@McKnight-42 McKnight-42 deleted the feature/materialized-views/ADAP-390 branch September 13, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

Assignees

@mikealfare mikealfare

@McKnight-42 McKnight-42

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2068] [Feature] Let's add Materialized View as a materialization, finally
2 participants
@mikealfare @McKnight-42