-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix whitespace issue with incremental sql #458
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple failing tests related to Python 3.11.
Could we take a look at those to determine the cause?
fixed python build issues for 3.11
- name: Install python dependencies | ||
run: | | ||
python -m pip install --user --upgrade pip | ||
python -m pip install --upgrade wheel | ||
python -m pip install --upgrade wheel setuptools twine check-wheel-contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did adding the following turn out to be necessary?
- setuptools
- twine
- check-wheel-contents
If they aren't strictly necessary, I'd advocate for peeling them out.
@@ -16,7 +16,7 @@ | |||
{{ wrap_with_time_ingestion_partitioning_sql(build_partition_time_exp(partition_by), sql, True) }} | |||
{%- else -%} | |||
{{sql}} | |||
{%- endif -%} | |||
{%- endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTW!
resolves #457
Description
Remove trailing whitespace elimination in bq_generate_incremental_merge_build_sql
Checklist
changie new
to create a changelog entry