fix validate connection failing #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/dbt-labs/dbt-bigquery/runs/6187865236?check_suite_focus=true looks like last night we had a failure in regards to this? do we know why it's happening? |
|
Yes, that's related to this. There was a PR in dbt-core which requires this pull request in BigQuery. |
ChenyuLInx
commented
Apr 27, 2022
|
|
||
| if self.profile.query_comment and self.profile.query_comment.job_label: | ||
| if ( | ||
| hasattr(self.profile, "query_comment") |
There was a problem hiding this comment.
This is the only meaningful change, others are just format fixes by black
gshank
approved these changes
Apr 27, 2022
ChenyuLInx
added a commit
that referenced
this pull request
Apr 27, 2022
* fix validate connection failing * fix code check * more format
ChenyuLInx
added a commit
that referenced
this pull request
Apr 27, 2022
* fix validate connection failing (#168)
siephen
pushed a commit
to AgencyPMG/dbt-bigquery
that referenced
this pull request
May 16, 2022
* fix validate connection failing * fix code check * more format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Description
make sure validate connection won't fail due to profile doesn't have comment
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.