Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_incremental_microbatch to use behavior flag instead of environment variable #1358

Closed
wants to merge 5 commits into from
Closed

Update test_incremental_microbatch to use behavior flag instead of environment variable #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4642ada
Update test_incremental_microbatch to use behavior flag instead of en…
QMalcolm Oct 1, 2024
938349a
Add changie doc
QMalcolm Oct 1, 2024
2ee4fd0
REVERT BEFORE MERGE: Temporarily point at dev branches of dbt-core an…
QMalcolm Oct 22, 2024
bb38f3b
Support updated/new microbatch tests provided by dbt-tests-adapter
QMalcolm Oct 22, 2024
2f4dc90
Merge branch 'main' into microbatch-behavior-flag
mikealfare Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20241001-164654.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: Update microbatch tests to use behavior flag instead of environment variable
time: 2024-10-01T16:46:54.905253-05:00
custom:
Author: QMalcolm
Issue: "1359"
6 changes: 3 additions & 3 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# install latest changes in dbt-core
git+https://github.com/dbt-labs/dbt-adapters.git
git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-adapters.git@microbatch-behavior-flag
git+https://github.com/dbt-labs/dbt-adapters.git@microbatch-behavior-flag#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-common.git
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@microbatch-project-flags#egg=dbt-core&subdirectory=core

# dev
ddtrace==2.3.0
Expand Down
29 changes: 25 additions & 4 deletions tests/functional/adapter/incremental/test_incremental_microbatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

from dbt.tests.util import run_dbt_and_capture
from dbt.tests.adapter.incremental.test_incremental_microbatch import (
BaseMicrobatch,
BaseTestMicrobatchOn,
BaseTestMicrobatchOff,
patch_microbatch_end_time,
)

Expand All @@ -16,7 +17,13 @@
)


class TestBigQueryMicrobatch(BaseMicrobatch):
class TestBigQueryMicrobatchOn(BaseTestMicrobatchOn):
@pytest.fixture(scope="class")
def microbatch_model_sql(self) -> str:
return microbatch_model_no_unique_id_sql


class TestBigQueryMicrobatchOff(BaseTestMicrobatchOff):
@pytest.fixture(scope="class")
def microbatch_model_sql(self) -> str:
return microbatch_model_no_unique_id_sql
Expand All @@ -30,7 +37,14 @@ def models(self) -> str:
"input_model.sql": microbatch_input_sql,
}

@mock.patch.dict(os.environ, {"DBT_EXPERIMENTAL_MICROBATCH": "True"})
@pytest.fixture(scope="class")
def project_config_update(self):
return {
"flags": {
"require_builtin_microbatch_strategy": True,
}
}

def test_execution_failure_no_partition_by(self, project):
with patch_microbatch_end_time("2020-01-03 13:57:00"):
_, stdout = run_dbt_and_capture(["run"], expect_pass=False)
Expand All @@ -45,7 +59,14 @@ def models(self) -> str:
"input_model.sql": microbatch_input_sql,
}

@mock.patch.dict(os.environ, {"DBT_EXPERIMENTAL_MICROBATCH": "True"})
@pytest.fixture(scope="class")
def project_config_update(self):
return {
"flags": {
"require_builtin_microbatch_strategy": True,
}
}

def test_execution_failure_no_partition_by(self, project):
with patch_microbatch_end_time("2020-01-03 13:57:00"):
_, stdout = run_dbt_and_capture(["run"], expect_pass=False)
Expand Down
Loading