-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BigQuery 'labels' and 'hours_to_expiration' configs for seeds #133
Support BigQuery 'labels' and 'hours_to_expiration' configs for seeds #133
Conversation
Hi @darrylng sorry for the wait on review if you could update to current main and push up to clear up current conflicts that would be great as it keeps your local in step with your pushed up pr. |
@darrylng it seems that we have added the pre-commit since you last updated, if you could update your local and run the pre-commit checks to make sure its passing should clear up the code-quality test. sorry for the delay in response. |
@darrylng really liking this tested locally and tests are passing, not sure why more aren't triggering here. if you could please update to latest in main and re push up (want to just keep your remote and local up to date with each other). but this is looking very good thus far great work! |
I have merged main branch into my forked branch but I believe the three tests that aren't running is because I'm a first time contributor and the workflow requires a maintainer to approve running it. |
Any chance we can get this reviewed? I'd love to see this feature soon as the current patchwork involves running macro to add labels after |
Any news on this request ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darrylng thank you for working on this sorry its taken longer than anticipated to get it in great work on this!
resolves #125
Description
This PR enables
+labels:
and+hours_to_expiration:
configs for seeds configuration. These labels are already implemented and used by models configuration to set table/view labels and expiration time, but was not done for seeded tables, reasons explained in issue #125.The initial change was to only implement
labels
config but on further dev, I noticed the addition ofALTER TABLE .. SET OPTION()
supports other options other thanlabels
, so the pytest was added to includehours_to_expiration
config test as well.These are the only two non-configs properties that are currently implemented in
dbt-bigquery
that will start to take effect with the change inseed.sql
.Checklist
CHANGELOG.md
and added information about my change to the "dbt-bigquery next" section.