Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New ENV var to file #116

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Adding New ENV var to file #116

merged 2 commits into from
Feb 11, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Feb 8, 2022

Description

adding a new BIGQUERY_TEST_NO_ACCESS_DATABASE env variable to main as we use current main branch to test against pr's so tests involving the new env var are currently failing

Will reference in changelog for primary PR as this is just a required pr to be able to properly test 111 and provide a simple integration test for community contribution.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-bigquery next" section.

@McKnight-42 McKnight-42 changed the title Adding New ENV to file Adding New ENV var to file Feb 8, 2022
@cla-bot cla-bot bot added the cla:yes label Feb 11, 2022
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @McKnight-42

@kwigley kwigley self-requested a review February 11, 2022 20:11
@McKnight-42
Copy link
Contributor Author

Thank you @kwigley

@McKnight-42 McKnight-42 merged commit d5d94f9 into main Feb 11, 2022
@McKnight-42 McKnight-42 deleted the mcknight/integration.yml branch February 11, 2022 20:14
@McKnight-42 McKnight-42 self-assigned this Mar 22, 2022
siephen pushed a commit to AgencyPMG/dbt-bigquery that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants