Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd removed logic for deferral fail-over #94

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

jtcohen6
Copy link
Contributor

The logic added in #60 (to support dbt-labs/dbt-core#9199) was removed in #55.

I'm not sure if there's a good way to test this within dbt-adapters by itself...

Problem

Logic added to failover to defer_relation if this is not present in the target schema. (I realize that the logic I added in #60 wasn't quite right, either!)

Solution

Check to see if this exists (cache lookup), then fail over to using defer_relation instead for column type detection.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@jtcohen6 jtcohen6 requested a review from MichelleArk February 19, 2024 16:07
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare merged commit 3deecde into main Feb 19, 2024
6 of 7 checks passed
@mikealfare mikealfare deleted the jerco/resupport-deferral-refactor branch February 19, 2024 16:39
gshank added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants