Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point CI testing to dev versions of internal dependencies #79

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Feb 12, 2024

Problem

There appears to be a missing dependency on the DBT_INVOCATION_CONTEXT_VAR context variable.

Solution

All testing dependencies should point to main to ensure that the latest changes are reflected.

  • Move all optional dependencies into hatch environments
    • They aren't production dependencies
    • We can't install from GitHub in optional dependencies and also publish to PyPI
  • Make the default environment the dev version of all production dependencies
  • Inherit from the default environment for non-detached hatch environments (typechecking and testing)
  • Remove integration test hatch environment since there are no integration tests
  • Pin lower bound for dependencies in alignment with our practices

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Feb 12, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare marked this pull request as ready for review February 12, 2024 21:43
@mikealfare mikealfare requested a review from a team February 12, 2024 23:28
@mikealfare mikealfare changed the title Migrate get catalog tests to base adapter Point CI testing to dev versions of internal dependencies Feb 13, 2024
@mikealfare mikealfare merged commit e05f696 into main Feb 13, 2024
6 checks passed
@mikealfare mikealfare deleted the tests/get-catalog branch February 13, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants